[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 15:02:26 PDT 2022


sunfish added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360
+      auto *GA = llvm::GlobalAlias::create("__main_void", F);
+      GA->setVisibility(F->getVisibility());
+    }
----------------
Can this use `GA->setVisibility(GlobalValue::HiddenVisibility)`? `__main_void` is an implementation detail, so in theory users shouldn't be setting interesting visibility attributes on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75277/new/

https://reviews.llvm.org/D75277



More information about the llvm-commits mailing list