[PATCH] D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl

Tue May 31 14:24:15 PDT 2022

rnk added inline comments.

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:827
+    endforeach()
+    if (CLANG_CL)
+      # Keep frame pointers around.
----------------
This isn't clang-specific, it's x86_32-specific.

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:897
+        if (${LLVM_USE_CRT_${uppercase_CMAKE_BUILD_TYPE}} MATCHES "^(MT|MTd)$")
+          append("/wholearchive:clang_rt.asan-x86_64.lib /wholearchive:clang_rt.asan_cxx-x86_64.lib"
+            CMAKE_EXE_LINKER_FLAGS)
----------------
This assumes x86_64, while i386 is also a possibility.

I wish we hadn't embedded the architecture into our library names. =/

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126706/new/

https://reviews.llvm.org/D126706