[PATCH] D126250: [CodeGen][AArch64] Add support for LDAPR

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 14:19:53 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:68
+def FeatureLDAPR : SubtargetFeature<"ldapr", "HasLDAPR", "true",
+  "Enable ARMv8.3 (optional in v8.2) RCPC LDAPR instruction">;
+
----------------
This description is a bit misleading; it's not about whether the instructions themselves are enabled.  It should explicitly say something "Use LDAPR to lower atomic loads; experimental until we have more testing/a formal correctness proof".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126250/new/

https://reviews.llvm.org/D126250



More information about the llvm-commits mailing list