[PATCH] D126715: [coro async] Add code to support dynamic aligment of over-aligned types in async frames

[John McCall via Phabricator via llvm-commits]

rjmccall added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1575
+            Builder.CreateSub(ConstantInt::get(IntPtrTy, AI->getAlignment()),
+                              ConstantInt::get(IntPtrTy, 1));
+        PtrValue = Builder.CreateAdd(PtrValue, AlignMask);
----------------
Surely just doing `AI->getAlignment() - 1` is simpler.

Can we trust `AI->getAlignment()` to be the same value as the alignment we used when computing the frame layout?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126715/new/

https://reviews.llvm.org/D126715