[PATCH] D126509: [Objcopy][Wasm] Allow selecting known sections by name

Tue May 31 11:18:34 PDT 2022

dschuff added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/wasm/remove-section.test:13
+# RUN: llvm-objcopy -R TYPE %t %t3
+# RUN: obj2yaml %t3 | FileCheck --check-prefix=REMOVETYPE --implicit-check-not=TYPE %s
+## Check that the producers section is still there.
----------------
sbc100 wrote:
> Why use `--implicit-check-not` instead of `CHECK-NOT` lines.  (I've never seen implicit-check-not used before).
implicit-check-not ensures that the text doesn't appear anywhere in the file at all. It's like having a CHECK-NOT in between all your CHECK lines, so it's much cleaner for that use case. In this particular case maybe it's not strictly necessary (since the type section could only go before the producers section) but it's used in several o the other objcopy tests, so it's consistent to use it here too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126509/new/

https://reviews.llvm.org/D126509