[PATCH] D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis.

[Mingming Liu via Phabricator via llvm-commits]

mingmingl marked an inline comment as done.
mingmingl added a comment.

The patch annotates SampleProfile inline, as well as the inline passes that talks to DefaultInlineAdvisor to get an advice (CGSCC, ModuleInline, ReplayInline).

Some rationale regarding why not all inline related passes are annotated:

1. The inline advisor interface exposes ORE instance (OptimizationRemarkEmitter) and four interfaces (like `recordInliningImpl`) to derived classes (protected methods and fields); so derived classes can decide what messages to emit and the pass name to use. From this perspective, non-trivial refactors and changes to existing interface class are necessary to "revoke" the derived classes' access to ORE instance.

2. Relatedly, AlwaysInliner and MLInliner use ORE instance without talking to InlineAdvisor interface (similar to sample-profile pass), which is actually much simpler to modify (that could be done in separate patches)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125495/new/

https://reviews.llvm.org/D125495