[PATCH] D125299: [ValueTracking] Enable -branch-on-poison-as-ub by default

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 09:56:59 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

Thank you for methodically working through all the issues found in the tests.

For the record, I think there's a very good chance that we end up reverting this change.  I will not be surprised at all to see failures reported because we missed some transform which had insufficient test coverage in tree.  Despite that, I think it's time to move this forward and start smoking out any remaining issues.

I do request that you try to land this at an off time.  Please pick a window where builbots can cycle quickly, and we can avoid having this end up in large build requests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125299/new/

https://reviews.llvm.org/D125299



More information about the llvm-commits mailing list