[PATCH] D126509: [Objcopy][Wasm] Allow selecting known sections by name

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/dump-section.test:24
+
+
 ## Check that dumping and removing a section works in the same invocation
----------------
Just only empty line here?


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/remove-section.test:13
+# RUN: llvm-objcopy -R TYPE %t %t3
+# RUN: obj2yaml %t3 | FileCheck --check-prefix=REMOVETYPE --implicit-check-not=TYPE %s
+## Check that the producers section is still there.
----------------
Why use `--implicit-check-not` instead of `CHECK-NOT` lines.  (I've never seen implicit-check-not used before).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126509/new/

https://reviews.llvm.org/D126509