[PATCH] D126012: [Scalarizer] Support loading from an extracted vector of pointer

Tue May 31 08:59:15 PDT 2022

nikic added a comment.

My current thinking here is that we shouldn't be making this gather() call at all. The code seems to be effectively treating the result of the extractelement as a 1-vector, which doesn't make a lot of sense to me.

I tried the following patch, that just replaces the extractelement with the scattered value: https://gist.github.com/nikic/d09ace51902e03e5b0cf04c528f87c49 Apart from one dead instruction, this seems to be working fine with tests.

What do you think?

================
Comment at: llvm/test/Transforms/Scalarizer/global-bug.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -passes='function(scalarizer)' -S | FileCheck %s
----------------
Spurious change :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126012/new/

https://reviews.llvm.org/D126012