[PATCH] D126675: [Windows] Don't try to wildcard expand paths starting with \\?\

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 08:24:53 PDT 2022


hans accepted this revision.
hans added a comment.

lgtm



================
Comment at: llvm/lib/Support/Windows/Process.inc:161
   if (Arg.find_first_of("*?") == StringRef::npos || Arg == "/?" ||
-      Arg == "-?") {
+      Arg == "-?" || Arg.startswith("\\\\?\\")) {
     Args.push_back(Arg.data());
----------------
Adding "Paths that start with \\?\ are absolute paths, and aren't expected to be used with wildcard expressions." to the comment would be good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126675/new/

https://reviews.llvm.org/D126675



More information about the llvm-commits mailing list