[PATCH] D126699: [CMake] Skip linker check if the LLVM_LINKER_WORKS is set

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 06:55:45 PDT 2022


thieta added a comment.

I think I rather would name the variable `LLVM_LINKER_SKIP_TEST` or something like that. I don't like the cmake variable name and since it's not something upstream we are adding I think I rather use a more descriptive name.

That said - I am a bit confused as to why this is not working correctly? Can you show how it fails when you need to set this variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126699/new/

https://reviews.llvm.org/D126699



More information about the llvm-commits mailing list