[PATCH] D126696: sanitizers: Do not include crypt.h if SANITIZER_INTERCEPT_CRYPT_R is undef

Tue May 31 06:32:03 PDT 2022

thakis added inline comments.

================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h:21
 #include "sanitizer_platform.h"
+#include "sanitizer_platform_interceptors.h"

----------------
thakis wrote:
> (not sure if adding this include here is proper?)
Ah hm, looks like it isn't: `sanitizer_platform_interceptors.h` includes `sanitizer_platform_limits_posix.h`.

Any suggestions on how prevent the crypt.h include if sanitizer_intercept_overriders.h sets `SANITIZER_INTERCEPT_CRYPT_R` to 0?

I guess I could keep the struct_crypt_data_sz declaration here and only omit its initialization in sanitizer_platform_limits_posix.cpp? Also a bit iffy, but maybe the best available option.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126696/new/

https://reviews.llvm.org/D126696