[PATCH] D126692: [InstCombine] Expand select+masked_load combine to include FP splats of -0.0

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 05:42:09 PDT 2022


paulwalker-arm added a comment.

In general how safe it is to use the function's `no-signed-zeros-fp-math` attribute to infer it's safe to convert one bit pattern to another?  Fair enough if we're dealing with floating point operations then we can ignore the signedness of zero but this is just doing a select of some loaded data, which could be immediately stored out.  So it feels dangerous to just change the data in this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126692/new/

https://reviews.llvm.org/D126692



More information about the llvm-commits mailing list