[PATCH] D125036: [RISCV] Alignment relaxation

[Luís Marques via Phabricator via llvm-commits]

luismarques added inline comments.


================
Comment at: lld/ELF/Arch/RISCV.cpp:539-540
+//
+// Fill the gaps created by adding bytes (when delta > 0) to the section:
+// * After a relaxation was undone, restore the original instruction.
+// * After the alignment gap length is known, fill with NOPs.
----------------
Sorry, where is this done?


================
Comment at: lld/ELF/InputSection.cpp:178
+        if (auto *isec = dyn_cast_or_null<InputSection>(d->section))
+          if (isec->flags & SHF_EXECINSTR) {
+            SymbolAddrs &symbolAddrs = sectionSymbolAddrs[isec];
----------------
This was changed but the tests didn't change. Sounds like an opportunity to improve test coverage?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125036/new/

https://reviews.llvm.org/D125036