[PATCH] D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`.

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 02:05:34 PDT 2022


bjope added a comment.

In D126257#3546857 <https://reviews.llvm.org/D126257#3546857>, @pcwalton wrote:

> Sorry for the delay. I was looking at this on Friday but didn't get around to finishing it. Feel free to revert in the meantime.

Well, this has already only caused me trouble. And since it isn't as trivial as to just revert a single commit I'm not saying that I really look forward to clean up the mess (I probably won't spend much time on explaining the reverts in the commit messages etc, but I guess I still need to follow up to make sure I haven't broken something that make build bots go crazy due to the reverts, so even more of my time being invested in this). If you are aware of the problem and doesn't have a quick solution I think you should react quicker and make the reverts yourself next time.

Anyway, I've landed the revert now!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126257/new/

https://reviews.llvm.org/D126257



More information about the llvm-commits mailing list