[PATCH] D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`.

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a subscriber: ayermolo.
bjope added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dwarf-aranges.ll:25
 ; CHECK-NEXT: .quad .Lfunc_begin0
-; CHECK-NEXT: .quad .Lsec_end2-.Lfunc_begin0
+; CHECK-NEXT: .quad 1
 
----------------
dblaikie wrote:
> bjope wrote:
> > I do not fully understand what happened here.
> > The old label range was not zero-sized, right? So this is not rounding up to 1 byte, it is truncating it down to 1 byte, right? Is that really the intention with the patch?
> Yep. Looks buggy to me - I guess maybe functions don't have a known size so appear to have size zero (when it's really unknown size) & that ends up overriding the real size computation.
> 
> @pcwalton might be worth reverting this to figure that out?
Still no comments from @pcwalton (nor @ayermolo who committed this patch).

I guess I can perform the revert while waiting for feedback. But then I also need to revert the follow-up commit by @DavidSpickett. Later when/if re-applying one would need to also re-apply that commit (and preferably also fix the problem with the align field in the dwarf-aranges-zero-size.ll test case discussed above).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126257/new/

https://reviews.llvm.org/D126257