[PATCH] D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/SSAUpdaterImpl.h:327
+  /// Check all predecessors and if all of them have the same AvailableVal
+  /// use it as val for block represented by Info. Return true if singluar value
+  /// is found.
----------------
Nit: s/val/value/


================
Comment at: llvm/include/llvm/Transforms/Utils/SSAUpdaterImpl.h:342
+    (*AvailableVals)[Info->BB] = Singular;
+    assert(BBMap[Info->BB] == Info && "Where Info from?");
+    Info->AvailableVal = Singular;
----------------
I'd like a message with more description.


================
Comment at: llvm/include/llvm/Transforms/Utils/SSAUpdaterImpl.h:364
 
+      // Look for singular val.
+      if (FindSingularVal(Info))
----------------
Nit: s/val/value/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126525/new/

https://reviews.llvm.org/D126525