[PATCH] D126641: [RISCV] Pass OptLevel to `RISCVDAGToDAGISel` correctly

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 30 17:25:02 PDT 2022


jrtc27 added a comment.

In D126641#3546557 <https://reviews.llvm.org/D126641#3546557>, @eopXD wrote:

> In D126641#3546498 <https://reviews.llvm.org/D126641#3546498>, @craig.topper wrote:
>
>> I see that this is how many other targets do it. It would have been helpful to mention that in the description so we immediately know you're not inventing something new.
>>
>> LGTM
>
> Yes you are right, I could have done better explaining my patch.
> I will try to mention how other targets do to bring in the context.
> Thank you for the swift review.

The commit message was identical to the original review summary?..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126641/new/

https://reviews.llvm.org/D126641



More information about the llvm-commits mailing list