[PATCH] D126544: [SLP] Factor out scalar type as a getter. NFC

[Yueh-Ting (eop) Chen via Phabricator via llvm-commits]

eopXD added a comment.

Thank you @RKSimon for raising this question.

Regarding the code that calls `->getType()` and don't have dynamic casts...

- Line 3494 can only be entered when instruction is a Instruction::Load.
- Use of line 3614 can only be used when TE.Scalars consist of Load instructions.
- Line 4909 is under `case Instruction::Load`
- Line 11147 is under the reduction part of SLP, by the cases in `RecurKind` I think load / store / cmp instructions are not involved here.

With all this said, I am not sure if any existing code will cause this "none functional change intended" patch to fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126544/new/

https://reviews.llvm.org/D126544