[PATCH] D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 30 05:32:07 PDT 2022


spatel added a comment.

In D126591#3544585 <https://reviews.llvm.org/D126591#3544585>, @bcl5980 wrote:

> I'm sorry but I have a question about the ninja check. What is difference between pre-merge checks and local ninja check test? I try to test local but a lot of test failures on bolt, clang, lld. There is no IR failure.

The pre-merge checks are probably running more/different tests on a variety of targets.

I'm not sure how reliable those results are. You can see similar failures for seemingly unrelated patches like D126638 <https://reviews.llvm.org/D126638>.

It is not necessary to pass all pre-merge tests before committing a patch - I think it is still experimental. If the failure is real, then bots and their owners will definitely let you know after you commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126591/new/

https://reviews.llvm.org/D126591



More information about the llvm-commits mailing list