[PATCH] D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values

Mon May 30 00:18:10 PDT 2022

sameerds added a comment.

In D126525#3544916 <https://reviews.llvm.org/D126525#3544916>, @skatkov wrote:

> In D126525#3544896 <https://reviews.llvm.org/D126525#3544896>, @sameerds wrote:
>
>> Even then, a target independent test in LLVM IR will certainly be useful.
>
> That would be good but SSA Updater is not triggered directly as a pass. I found the motivation case in tailduplication codegen pass, so I've written it in mir format. Writing it in LLVM IR will just include a lot of other passes where the changes might disappear the case I'm testing. I though the more precise test is better than something general.
>
> If you'd like I can try to create unittest triggering directly SSA Updater.

I see now. I looked into the places where SSAUpdater is used, and I am okay with not having an LLVM IR or unit test here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126525/new/

https://reviews.llvm.org/D126525