[PATCH] D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 29 21:56:10 PDT 2022


sameerds added a comment.

In D126525#3544805 <https://reviews.llvm.org/D126525#3544805>, @skatkov wrote:

> In D126525#3542391 <https://reviews.llvm.org/D126525#3542391>, @djtodoro wrote:
>
>> This is interesting! Can you please make a simple/dedicated LLVM IR case for this only, so we can go over the example to get the whole picture?
>
> llvm/test/CodeGen/AArch64/tail-dup-redundant-phi.mir is dedicated test for this patch and https://reviews.llvm.org/D126523. This test is not landed yet. I just uploaded it here as diff to show the difference.

Even then, a target independent test in LLVM IR will certainly be useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126525/new/

https://reviews.llvm.org/D126525



More information about the llvm-commits mailing list