[PATCH] D126488: [RISCV] reorganize comments in getFrameIndexReference [nfc]

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck requested changes to this revision.
frasercrmck added a comment.
This revision now requires changes to proceed.

No, I think the FP path is indeed different. The offsetting code lines up with the comment, doesn't it? That's what I gathered when working on this recently, anyway - I don't have the ability to verify it right now. I don't think it's correct to remove that comment wholesale. The only thing coming to me right now is a comment somewhere (code, commit - sorry) saying we want to put RVV objects as far away from the frame register as possible, hence the scalar/RVV swap when using FP. Or would that be better worded as "scalar as //close// to the frame register as possible"?

I do think we might be lacking RVV+FP testing. That was something I was going to look into.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126488/new/

https://reviews.llvm.org/D126488