[PATCH] D126550: Make report_fatal_error respect its GenCrashDiag argument so it doesn't generate a backtrace

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Support/ErrorHandling.cpp:125
+  else
+    exit(-1);
 }
----------------
https://www.opengroup.org/austin/docs/austin_1110.pdf

"Calling exit() with a value greater than 255 or less than 0 is something that only programs
which are specifically designed to have their exit status obtained by waitid() should do
(since it does not truncate the exit status to 8 bits). ``Pure ISO C’’ programs that call
exit(EXIT_FAILURE) do not meet this design criterion."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126550/new/

https://reviews.llvm.org/D126550