[PATCH] D126173: [VPlan] Use Exiting-block instead of Exit-block terminology (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks Ayal! Comments should be updated in the committed version.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:333
     // ExitBB can be re-used for the exit block of the Plan.
     NewBB = State->CFG.ExitBB;
     State->CFG.PrevBB = NewBB;
----------------
Ayal wrote:
> ExitBB should remain as such, right?
Yes, it is the block we exit to.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp:332
   TopRegion->setEntry(PreheaderVPBB);
-  TopRegion->setExit(LoopExitVPBB);
+  TopRegion->setExiting(LoopExitVPBB);
   return TopRegion;
----------------
Ayal wrote:
> LoopExitingVPBB?
This is an oddity of the current outer-loop VPlans. Should be cleaned up in D123005


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126173/new/

https://reviews.llvm.org/D126173