[PATCH] D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 28 11:50:49 PDT 2022


spatel added a comment.

In D126591#3544029 <https://reviews.llvm.org/D126591#3544029>, @bcl5980 wrote:

> So can we write transforms below to fix this issue?:
> https://alive2.llvm.org/ce/z/DiF6Wo
> https://alive2.llvm.org/ce/z/nQtvt5

Yes, it is worth trying. After you create those, run tests (`ninja check` at least and possibly test-suite) and see if it uncovers any regressions. Also, check the assembly output for each of those patterns and verify that most in-tree targets (x86, AArch/ARM, riscv) show improvements.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126591/new/

https://reviews.llvm.org/D126591



More information about the llvm-commits mailing list