[PATCH] D123515: [RISCV] Support '.option arch' directive
luxufan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 28 00:45:33 PDT 2022
StephenFan marked an inline comment as done.
StephenFan added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2131-2133
+ Parser.Lex();
+
+ Parser.parseComma();
----------------
luismarques wrote:
> Don't we need to check for errors here?
`parseComma` would raise an error if the token is not the comma. Does this make you happy?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123515/new/
https://reviews.llvm.org/D123515
More information about the llvm-commits
mailing list