[PATCH] D126543: [bazel] BLAKE3: Adopt aarch64 and x86_64.

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 15:04:09 PDT 2022


chapuni marked an inline comment as done.
chapuni added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:205
+            "lib/Support/BLAKE3/blake3_avx512_x86-64_unix.S",
+        ],
+    }),
----------------
MaskRay wrote:
> https://docs.bazel.build/versions/main/configurable-attributes.html#the-default-condition there should be a `//conditions:default` condition for non-aarch64-nonx86_64 CPUs.
I misunderstood to expect noop w/o `default` and I have confirmed `default:[]` is essential here. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126543/new/

https://reviews.llvm.org/D126543



More information about the llvm-commits mailing list