[PATCH] D125870: [Polly] Migrate -polly-mse to the new pass manager.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM

Would you like me to commit for you?



================
Comment at: polly/lib/Transform/MaximalStaticExpansion.cpp:520
+  OptimizationRemarkEmitter *ORE =
+      &(getAnalysis<OptimizationRemarkEmitterWrapperPass>().getORE());
 
----------------
[style] Unnecessary parens.



================
Comment at: polly/lib/Transform/MaximalStaticExpansion.cpp:526
 
-    if (SAI->isValueKind() || SAI->isArrayKind()) {
-      assert(AllWrites.size() == 1 || SAI->isValueKind());
-
-      auto TheWrite = *(AllWrites.begin());
-      ScopArrayInfo *ExpandedArray = expandAccess(S, TheWrite);
-
-      mapAccess(S, AllReads, Dependences, ExpandedArray, true);
-    } else if (SAI->isPHIKind()) {
-      expandPhi(S, SAI, Dependences);
-    }
-  }
+  auto Impl = runMaximalStaticExpansion(S, *ORE, D);
 
----------------
[style] No almost-always-auto.

Here it helps to see that MaximalStaticExpansionImpl will be released by RAII


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125870/new/

https://reviews.llvm.org/D125870