[PATCH] D126553: [WebAssembly] Consolidate sectionTypeToString in BinaryFormat [NFC]

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 08:33:39 PDT 2022


sbc100 added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:475
 std::string relocTypetoString(uint32_t type);
+llvm::StringRef sectionTypeToString(uint32_t type);
 bool relocTypeHasAddend(uint32_t type);
----------------
Use `std::string` for consistency with the two above?  Or convert them all the StringRef?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126553/new/

https://reviews.llvm.org/D126553



More information about the llvm-commits mailing list