[PATCH] D126535: [WebAssembly][NFC] Update reftype and table tests to use opaque pointers

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 06:51:26 PDT 2022


sbc100 added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/externref-globalset.ll:3
 
-%extern = type opaque
-%externref = type %extern addrspace(10)* ;; addrspace 10 is nonintegral
+%externref = type ptr addrspace(10) ;; addrspace 10 is nonintegral
 
----------------
So the old code used `type opaque` and the new code just uses `ptr`?     But I take that the `ptr` is also somehow implicitly "opaque".. otherwise the PR description would not make sense?   (Sorry i'm not familiar the opaque pointer stuff).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126535/new/

https://reviews.llvm.org/D126535



More information about the llvm-commits mailing list