[PATCH] D126527: Remove `deplibs` keyword completely

Yuki Okushi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 06:31:37 PDT 2022


JohnTitor updated this revision to Diff 432541.
JohnTitor added a comment.
Herald added a subscriber: mehdi_amini.
Herald added a project: Flang.

[Flang] Use `signalPassFailure()` on unsupported targets

A fatal error is inconvinience for users, `signalPassFailure` should be enough.

Fixes #55015


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126527/new/

https://reviews.llvm.org/D126527

Files:
  flang/lib/Optimizer/CodeGen/Target.cpp
  llvm/include/llvm/AsmParser/LLToken.h


Index: llvm/include/llvm/AsmParser/LLToken.h
===================================================================
--- llvm/include/llvm/AsmParser/LLToken.h
+++ llvm/include/llvm/AsmParser/LLToken.h
@@ -88,7 +88,6 @@
   kw_triple,
   kw_source_filename,
   kw_unwind,
-  kw_deplibs, // FIXME: Remove in 4.0
   kw_datalayout,
   kw_volatile,
   kw_atomic,
Index: flang/lib/Optimizer/CodeGen/Target.cpp
===================================================================
--- flang/lib/Optimizer/CodeGen/Target.cpp
+++ flang/lib/Optimizer/CodeGen/Target.cpp
@@ -291,5 +291,6 @@
     }
     break;
   }
-  llvm::report_fatal_error("target not implemented");
+  mlir::emitError(mlir::UnknownLoc::get(&context), "target is not supported");
+  signalPassFailure();
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126527.432541.patch
Type: text/x-patch
Size: 759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220527/aebf9a87/attachment.bin>


More information about the llvm-commits mailing list