[PATCH] D126506: workflows: Use new custom runners from github

Alexander Batashev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 23:13:42 PDT 2022


alexbatashev added a comment.

Comments below are totally unrelated to this patch, I'm just curious.



================
Comment at: .github/workflows/clang-tests.yml:12-17
   pull_request:
     paths:
       - 'clang/**'
       - '.github/workflows/clang-tests.yml'
       - '.github/workflows/llvm-project-tests.yml'
       - '!llvm/**'
----------------
What's the reason to include pull_request here if all pull requests are automatically closed?


================
Comment at: .github/workflows/llvm-project-tests.yml:39-45
       - name: Setup Windows
         if: startsWith(matrix.os, 'windows')
         uses: llvm/actions/setup-windows at main
         with:
           arch: amd64
       - name: Install Ninja
         uses: llvm/actions/install-ninja at main
----------------
Did you consider using sccache here? I see that right now this job takes ~4 hours, and the majority of time is spent on builds, which correlates with my experience building llvm in github actions. Enabling sccache should bring that down to ~3-15 minutes (windows is still much slower than linux, but that's a big improvement over a few hours).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126506/new/

https://reviews.llvm.org/D126506



More information about the llvm-commits mailing list