[PATCH] D125712: [SLP][X86] Improve reordering to consider alternate instruction bundles

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2381
+    /// even and odd opcodes, like: OpcA, OpcB, OpcA, OpcB.
+    bool isAltShuffleWithRepeatingEvenOddOpcodes() const {
+      if (!isAltShuffle())
----------------
I'd say we don't really need this interface.
IMO what is likely to be more useful is something like buildAltShuffleMask which you could directly feed into the TTI interface you added. See also buildShuffleEntryMask which could also benefit from having it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125712/new/

https://reviews.llvm.org/D125712