[PATCH] D125905: [RISCV] Fix state persistence bugs (PR55548)
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 26 18:11:50 PDT 2022
MaskRay added inline comments.
================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:236
+ MCTargetStreamer &TS = *getTargetStreamer();
+ RISCVTargetStreamer &RTS = static_cast<RISCVTargetStreamer &>(TS);
+ RTS.reset();
----------------
kito-cheng wrote:
> MaskRay wrote:
> > RTS should be omitted.
> `MCTargetStreamer` didn't provide `reset`, that's provided by `RISCVTargetStreamer`.
My comment is more about: defining a variable is unnecessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125905/new/
https://reviews.llvm.org/D125905
More information about the llvm-commits
mailing list