[PATCH] D126509: [Objcopy][Wasm] Allow selecting known sections by name

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 17:01:23 PDT 2022


sbc100 added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:475
 std::string relocTypetoString(uint32_t type);
+llvm::StringRef sectionTypeToString(uint32_t type);
 bool relocTypeHasAddend(uint32_t type);
----------------
Seems like we should be consistent here with std::string vs StringRef.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126509/new/

https://reviews.llvm.org/D126509



More information about the llvm-commits mailing list