[PATCH] D126497: [lld][WebAssemlby] Check for command line flags with missing arguments

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 13:23:39 PDT 2022


sbc100 added inline comments.


================
Comment at: lld/wasm/Driver.cpp:187
   handleColorDiagnostics(args);
+  if (missingCount)
+    error(Twine(args.getArgString(missingIndex)) + ": missing argument");
----------------
dschuff wrote:
> this bit looks separate from the 'reproduce' parts, and the commit message only indicates about this. were they intended to be separate CLs?
Sorry, yes, two changes in one.. split them up now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126497/new/

https://reviews.llvm.org/D126497



More information about the llvm-commits mailing list