[PATCH] D126411: update_mir_test_checks: Better handling of common prefixes

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 13:16:19 PDT 2022


arichardson added a comment.

In D126411#3540256 <https://reviews.llvm.org/D126411#3540256>, @nhaehnle wrote:

> In D126411#3538893 <https://reviews.llvm.org/D126411#3538893>, @arichardson wrote:
>
>> This looks reasonable to me, would it be possible to add a test showing the new behaviour?
>
> Yeah, I was wondering about that as well. Do you have any advice on how to do that? I didn't find any pre-existing tests, and it seems somewhat tricky to set up given that it's subject to changes in the code generator.

There is one mir test: https://github.com/llvm/llvm-project/tree/main/llvm/test/tools/UpdateTestChecks/update_mir_test_checks 
I agree these tests are rather awkward since they depend on the codegen, but as long as they are simple there shouldn't be too many changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126411/new/

https://reviews.llvm.org/D126411



More information about the llvm-commits mailing list