[PATCH] D126392: [RISCV] Use two ADDIs to do some stack pointer adjustments.

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 12:03:37 PDT 2022


arichardson added a comment.

In D126392#3540178 <https://reviews.llvm.org/D126392#3540178>, @luismarques wrote:

> In D126392#3539458 <https://reviews.llvm.org/D126392#3539458>, @arichardson wrote:
>
>> This may break assumptions that some unwinding code uses (e.g. an kernel backtrace without debug info). But then again I don't know if any of them handle non-immediate offsets anyway.
>
> What do you mean? Unwinding with neither the frame pointer nor CFI?

Yeah I've seen such implementations for MIPS, maybe there are some for RISC-V too. This was not meant as a request to change anything, no one should rely on specific code generation patterns unless it's mandated by a specification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126392/new/

https://reviews.llvm.org/D126392



More information about the llvm-commits mailing list