[PATCH] D126421: ADT/ArrayRef: Add makeMutableArrayRef overloads

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/ADT/ArrayRef.h:549
+
+  template <typename T, unsigned N>
+  MutableArrayRef<T> makeMutableArrayRef(SmallVector<T, N> &Vec) {
----------------
efriedma wrote:
> Missing doc comment?
Adding a comment for each makeMutableArrayRef overload doesn't add much value to me. The argument types are obvious.

I think having one comment covering all the overloads suffices.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126421/new/

https://reviews.llvm.org/D126421