[PATCH] D126491: [lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 11:40:03 PDT 2022


sbc100 created this revision.
Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, jgravelle-google, dschuff.
Herald added a project: All.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

We have some special handling for weakly defined symbols where we both
import and export them, but this is not needed for hidden symbols which
should never be imported or exported.

See https://github.com/emscripten-core/emscripten/pull/16972

This should also help with:
https://github.com/emscripten-core/emscripten/issues/15487


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126491

Files:
  lld/test/wasm/shared-weak-symbols.s
  lld/wasm/Symbols.cpp
  lld/wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126491.432341.patch
Type: text/x-patch
Size: 3669 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220526/58c83378/attachment.bin>


More information about the llvm-commits mailing list