[PATCH] D126087: [BOLT][DWARF] Fix TU Index handling for DWARF4/5.

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:738
+        else {
+          llvm::errs() << "BOT-ERROR: DW_AT_signature form is not supported.\n";
+          exit(1);
----------------



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1266
+static std::string extractDWOTUFromDWP(
+    DWARFRewriter::DebugTypesSignaturesPerCUMap &TypeSignaturesPerCU,
+    const DWARFUnitIndex &TUIndex, StringRef Contents,
----------------
Should this be `const`?


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1316
+    const MCObjectFileInfo &MCOFI, const DWARFUnitIndex &TUIndex,
+    DWARFRewriter::DebugTypesSignaturesPerCUMap &TypeSignaturesPerCU,
+    MCStreamer &Streamer, StringRef Contents, uint64_t DWOId) {
----------------



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1334-1336
+  for (const auto *C : TUContributions) {
+    Streamer.emitBytes(Contents.slice(C->Offset, C->Offset + C->Length));
+  }
----------------



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1405
+    } else if (Version != CU->getVersion()) {
+      llvm::errs() << "BOLT-ERROR: Incompatible DWARF compile unit versions.\n";
+      exit(1);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126087/new/

https://reviews.llvm.org/D126087