[PATCH] D126483: [AMDGPU] gfx11 vop3dpp instructions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

Not all cases checked for assembly also present in disasm test.



================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5695
 
-  if (Name.endswith("_e64")) {
+  if (Name.endswith("_e64_dpp")) {
+    setForcedDPP(true);
----------------
Technically that is _e96, but OK for now.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:444
+                                          Address);
+      if (Res) break;
+    }
----------------
break on new line.


================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:460
+                    Src1DPP:$src1,
+                   dpp8:$dpp8, FI:$fi);
 
----------------
Indent is off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126483/new/

https://reviews.llvm.org/D126483