[PATCH] D126475: [AMDGPU] gfx11 vop3 instructions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOPInstructions.td:1127
+  // VOP1 and VOP2 depend on these triple defs
+  multiclass VOP3_Realtriple_gfx11<bits<10> op,
+                                   bit isSingle = 0, string opName = NAME> :
----------------
Indent is misleading, the brace was closed above.


================
Comment at: llvm/test/MC/AMDGPU/gfx11_vop123.s:1
+// RUN: llvm-mc -arch=amdgcn -show-encoding -mcpu=gfx1100 %s | FileCheck --check-prefix=GFX11 %s
+
----------------
You probably need W32 and W64 run lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126475/new/

https://reviews.llvm.org/D126475