[PATCH] D126488: [RISCV] reorganize comments in getFrameIndexReference [nfc]
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 26 09:59:50 PDT 2022
reames created this revision.
reames added reviewers: StephenFan, kito-cheng, frasercrmck, craig.topper.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, bollu, simoncook, johnrusso, rbar, asb, hiraditya, arichardson, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.
Follow up to D126403 <https://reviews.llvm.org/D126403>. Reduce comment duplication, and give a high level description of what the code is doing.
For specific review attention, notice that the comment blocks being removed do not agree. In particular, they differ in the order of RVV Objects and scalar local variables. I believe the comment in the FP register path to have simply been wrong, do others agree?
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D126488
Files:
llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126488.432321.patch
Type: text/x-patch
Size: 6214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220526/43c9c294/attachment.bin>
More information about the llvm-commits
mailing list