[PATCH] D126388: [AMDGPU][GFX9] Support base+soffset+offset SMEM stores.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 08:16:01 PDT 2022


dp accepted this revision.
dp added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:604
+class SMEM_Real_Store_vi <bits<8> op, string ps, dag offsets>
+    : SMEM_Real_Store_Probe_vi <op, !cast<SM_Pseudo>(ps)> {
+  RegisterClass SrcClass = !cast<SM_Store_Pseudo>(ps).SrcClass;
----------------
This is a matter of taste, but I'd have renamed SMEM_Real_Store_Probe_vi to SMEM_Real_Store_Base_vi.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126388/new/

https://reviews.llvm.org/D126388



More information about the llvm-commits mailing list