[PATCH] D126403: [RISCV] reorganize getFrameIndexReference to reduce code duplication [nfc]
luxufan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 26 07:16:17 PDT 2022
StephenFan added a comment.
Thanks for refactoring it! I think it's fully NFC.
================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:794
+ // | scalar local variables | | <----'
+ // |--------------------------| -- <-- SP
+ //
----------------
Do you think it would be better to mention the BP here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126403/new/
https://reviews.llvm.org/D126403
More information about the llvm-commits
mailing list