[PATCH] D123515: [RISCV] Support '.option arch' directive

[Luís Marques via Phabricator via llvm-commits]

luismarques added inline comments.
Herald added a subscriber: shiva0217.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2131-2133
+    Parser.Lex();
+
+    Parser.parseComma();
----------------
Don't we need to check for errors here?


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2170-2171
+
+    // TODO: Enable or disable extension according to extension and extension
+    // version number. Currently extension version number is not supported.
+    if (Extension.find_if(isDigit) != StringRef::npos)
----------------
Past reviews mentioned that the plan going forward is for extensions to be immutable and not rely on version numbers. Unless that has changed again, we can delete this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515