[PATCH] D126177: [BOLT] [AArch64] Handle data markers spanning multiple functions

[Denis via Phabricator via llvm-commits]

treapster added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:1646
+  // end of a data chunk inside code, $d indentifies start of data.
+  if (!isAArch64() || ELFSymbolRef(Symbol).getSize())
+    return MarkerSymType::NONE;
----------------
tschuett wrote:
> do you want to make the AARCH64 check an assert?
No, i'm saying the opposite: if we remove a call to isAArch64 from here, we remove dependency on BinaryContext and use the function without it, and check arch separately when we need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126177/new/

https://reviews.llvm.org/D126177