[PATCH] D126442: [LegalizeTypes][VP] Add widen and split support for VP_SIGN_EXTEND and VP_ZERO_EXTEND.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1052
+  case ISD::VP_ZERO_EXTEND:
     SplitVecRes_ExtendOp(N, Lo, Hi);
     break;
----------------
craig.topper wrote:
> You should call SplitVecRes_UnaryOp for VP_SIGN_EXTEND/VP_ZERO_EXTEND. There's code in SplitVecRes_ExtendOp that hasn't been updated for VP intrinsics. I'm not sure if it can be exercised or not. But best to avoid it and leave a FIXME.
Done, I changed SplitVecRes_UnaryOp to support VP op.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126442/new/

https://reviews.llvm.org/D126442